uros-db commented on code in PR #46166:
URL: https://github.com/apache/spark/pull/46166#discussion_r1598281769
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -759,34 +761,38 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHelper {
}
test("hash based joins not allowed for non-binary collated strings") {
- val in = (('a' to 'z') ++ ('A' to 'Z')).map(_.toString * 3).map(e =>
Row.apply(e, e))
+ spark.conf.set("spark.sql.codegen.wholeStage", false)
+ val in = (('a' to 'b') ++ ('A' to 'B')).map(_.toString).map(e =>
Row.apply(e, e))
Review Comment:
yes! overall I'd say this PR is still a prototype, so tests may stay messy
until we converge on the correct approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
