uros-db commented on code in PR #46503:
URL: https://github.com/apache/spark/pull/46503#discussion_r1597873492
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -1151,6 +1151,23 @@ class CollationSQLExpressionsSuite
})
}
+ test("Support InputFileName expression with collation") {
+ // Supported collations
+ Seq("UTF8_BINARY", "UTF8_BINARY_LCASE", "UNICODE",
"UNICODE_CI").foreach(collationName => {
Review Comment:
I'd say most of the time tests are custom, depending on the function, and
only rarely do we have functions with no parameters - so this is not very
common (actually, this may be the only such function in this test suite). So
I'd say there's no need for a preset suite-level collation name collection.
On the other hand, we will soon have hundreds/thousands of collations in
Spark, so these 4 collations will soon appear to be very random (i.e. we won't
run this test for **all** supported collations, but these 4 should still be
enough to cover all cases for all functions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
