uros-db commented on code in PR #46561:
URL: https://github.com/apache/spark/pull/46561#discussion_r1599697850
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -1275,6 +1275,38 @@ class CollationSQLExpressionsSuite
})
}
+ test("DateFormat expression with collation") {
+ case class DateFormatTestCase[R](date: String, format: String, collation:
String, result: R)
+ val testCases = Seq(
+ DateFormatTestCase("2021-01-01", "yyyy-MM-dd", "UTF8_BINARY",
"2021-01-01"),
+ DateFormatTestCase("2021-01-01", "yyyy-dd", "UTF8_BINARY_LCASE",
"2021-01"),
+ DateFormatTestCase("2021-01-01", "yyyy-MM-dd", "UNICODE", "2021-01-01"),
+ DateFormatTestCase("2021-01-01", "yyyy", "UNICODE_CI", "2021")
+ )
+
+ for {
+ collateDate <- Seq(true, false)
+ collateFormat <- Seq(true, false)
+ } {
+ testCases.foreach(t => {
+ val dateArg = if (collateDate) s"collate('${t.date}',
'${t.collation}')" else s"'${t.date}'"
+ val formatArg =
+ if (collateFormat) {
+ s"collate('${t.format}', '${t.collation}')"
+ } else {
+ s"'${t.format}'"
+ }
+
+ withSQLConf(SqlApiConf.DEFAULT_COLLATION -> t.collation) {
+ val query = s"SELECT date_format(${dateArg}, ${formatArg})"
Review Comment:
my bad then, but please do fix the failing test:
`DateFormat expression with collation *** FAILED ***`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
