dbatomic commented on code in PR #46247:
URL: https://github.com/apache/spark/pull/46247#discussion_r1600124892
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingDeduplicationSuite.scala:
##########
@@ -484,6 +486,52 @@ class StreamingDeduplicationSuite extends
StateStoreMetricsTest {
CheckLastBatch(("c", 9, "c"))
)
}
+
+ test("collation aware deduplication") {
+ val inputData = MemoryStream[(String, Int)]
+ val result = inputData.toDF()
+ .select(col("_1")
+ .try_cast(StringType("UNICODE")).as("str"),
Review Comment:
In theory, it should work, but we need to test this as well.
binary ordering means that you can use binary representation to check which
string alphabetically comes first. But if we care only about equality (which is
usually used in "groupings" and joins), binary equality is only important.
I will follow up with additional testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
