nikolamand-db commented on code in PR #46180:
URL: https://github.com/apache/spark/pull/46180#discussion_r1601306785
##########
connector/connect/common/src/main/protobuf/spark/connect/types.proto:
##########
@@ -101,7 +101,7 @@ message DataType {
message String {
uint32 type_variation_reference = 1;
- uint32 collation_id = 2;
+ string collation = 2;
Review Comment:
This is protobuf collation field used by Spark Connect. We wanted to
decouple knowledge about collation ids in Spark Connect client and server in
order to make collation ids as internal as possible, thus we're not serializing
collation id anymore but collation name instead.
This enables us to forget about collation ids in PySpark and use only
collation name which can be an arbitrary string and all logic of
parsing/validating will be run on Scala side, so we don't need to have
duplicate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
