gengliangwang commented on code in PR #46502:
URL: https://github.com/apache/spark/pull/46502#discussion_r1602614245
##########
common/utils/src/main/java/org/apache/spark/internal/SparkLoggerFactory.java:
##########
@@ -17,15 +17,17 @@
package org.apache.spark.internal;
+// checkstyle.off: RegexpSinglelineJava
+import org.slf4j.LoggerFactory;
+// checkstyle.on: RegexpSinglelineJava
+
public class SparkLoggerFactory {
public static SparkLogger getLogger(String name) {
- org.slf4j.Logger slf4jLogger = org.slf4j.LoggerFactory.getLogger(name);
- return new SparkLogger(slf4jLogger);
+ return new SparkLogger(LoggerFactory.getLogger(name));
Review Comment:
yeah this looks better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
