mihailom-db commented on code in PR #46618: URL: https://github.com/apache/spark/pull/46618#discussion_r1603211716
########## sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala: ########## @@ -1584,6 +1584,240 @@ class CollationSQLExpressionsSuite }) } + test("CurrentTimeZone expression with collation") { + // Supported collations + Seq("UTF8_BINARY", "UTF8_BINARY_LCASE", "UNICODE", "UNICODE_CI").foreach(collationName => { + val query = + s""" + |select current_timezone() + |""".stripMargin Review Comment: practice is that if a string can go to one line we should do it, and this one seems small enough -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org