cloud-fan commented on code in PR #46613:
URL: https://github.com/apache/spark/pull/46613#discussion_r1604442771
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala:
##########
@@ -997,6 +997,32 @@ class CollationSQLExpressionsSuite
})
}
+ test("Support CurrentDatabase/Catalog/User expressions with collation") {
+ // Supported collations
+ Seq("UTF8_BINARY_LCASE", "UNICODE", "UNICODE_CI").foreach(collationName =>
+ withSQLConf(SqlApiConf.DEFAULT_COLLATION -> collationName) {
+ val queryDatabase = sql("SELECT current_schema()")
+ val queryCatalog = sql("SELECT current_catalog()")
+ val queryUser = sql("SELECT current_user()")
+ // Result
Review Comment:
This patch only changes return types and we should only test data types, not
results. We should avoid duplicated tests to reduce overhead when we make
behavior changes in the future and need to update tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
