GideonPotok commented on code in PR #46597: URL: https://github.com/apache/spark/pull/46597#discussion_r1604955632
########## sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/CollationBenchmark.scala: ########## @@ -185,6 +189,32 @@ abstract class CollationBenchmarkBase extends BenchmarkBase { } benchmark.run() } + + def benchmarkMode( Review Comment: I would love to add some E2E Benchmark tests. But it is okay if not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org