dbatomic commented on code in PR #46665:
URL: https://github.com/apache/spark/pull/46665#discussion_r1606711555
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -42,6 +42,25 @@ options { tokenVocab = SqlBaseLexer; }
public boolean double_quoted_identifiers = false;
}
+batchOrSingleStatement
+ : batchCompound SEMICOLON* EOF
Review Comment:
We should figure out the naming.
We should be clear about what is `batch` and what is a `compound`. At this
moment line is blurry.
Also, we should follow same rules as singleStatement - let's avoid EOF check
here, but add something like `singleBatch` which will contain EOF check at the
end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
