nikolamand-db commented on code in PR #46180:
URL: https://github.com/apache/spark/pull/46180#discussion_r1606746445
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -772,12 +772,17 @@ object SQLConf {
" produced by a builtin function such as to_char or CAST")
.version("4.0.0")
.stringConf
- .checkValue(CollationFactory.isValidCollation,
+ .checkValue(
+ collationName => {
+ try {
+ CollationFactory.fetchCollation(collationName)
+ true
+ } catch {
+ case e: SparkException if e.getErrorClass ==
"COLLATION_INVALID_NAME" => false
+ }
+ },
Review Comment:
Resolving the discussion, we removed `isValidCollation` from
`CollationFactory` and chose to scope it to only here as it's logic of catching
exception as part of control flow is not a good approach for general-purpose
utility function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
