LuciferYang commented on code in PR #46678:
URL: https://github.com/apache/spark/pull/46678#discussion_r1607774195
##########
core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala:
##########
@@ -54,9 +55,9 @@ private[spark] class SparkHadoopUtil extends Logging {
* Runs the given function with a Hadoop UserGroupInformation as a thread
local variable
* (distributed to child threads), used for authenticating HDFS and YARN
calls.
*
- * IMPORTANT NOTE: If this function is going to be called repeated in the
same process
- * you need to look https://issues.apache.org/jira/browse/HDFS-3545 and
possibly
- * do a FileSystem.closeAllForUGI in order to avoid leaking Filesystems
+ * IMPORTANT NOTE: If this function is going to be called repeated in the
same process you need
Review Comment:
Is there any change in the comment content? If not, please don't make
unnecessary format modifications.
##########
core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala:
##########
@@ -142,15 +143,16 @@ private[spark] class SparkHadoopUtil extends Logging {
if (!new File(keytabFilename).exists()) {
throw new SparkException(s"Keytab file: ${keytabFilename} does not
exist")
} else {
- logInfo("Attempting to login to Kerberos " +
- s"using principal: ${principalName} and keytab: ${keytabFilename}")
+ logInfo(
Review Comment:
just re-format?
##########
core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala:
##########
@@ -87,8 +88,8 @@ private[spark] class SparkHadoopUtil extends Logging {
}
/**
- * Appends spark.hadoop.* configurations from a [[SparkConf]] to a Hadoop
- * configuration without the spark.hadoop. prefix.
+ * Appends spark.hadoop.* configurations from a [[SparkConf]] to a Hadoop
configuration without
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
