yaooqinn commented on code in PR #46679:
URL: https://github.com/apache/spark/pull/46679#discussion_r1608004912
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -7209,8 +7209,8 @@ object functions {
* Returns length of array or map.
*
* This function returns -1 for null input only if spark.sql.ansi.enabled is
false and
- * spark.sql.legacy.sizeOfNull is true. Otherwise, it returns null for null
input.
- * With the default settings, the function returns null for null input.
+ * spark.sql.legacy.sizeOfNull is true. Otherwise, it returns null for null
input. With the
Review Comment:
Why do we make changes here while keeping AS-IS for
`org.apache.spark.sql.functions#size`?
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -7687,8 +7687,8 @@ object functions {
* Returns length of array or map. This is an alias of `size` function.
*
* This function returns -1 for null input only if spark.sql.ansi.enabled is
false and
- * spark.sql.legacy.sizeOfNull is true. Otherwise, it returns null for null
input.
- * With the default settings, the function returns null for null input.
+ * spark.sql.legacy.sizeOfNull is true. Otherwise, it returns null for null
input. With the
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
