HeartSaVioR commented on code in PR #46692:
URL: https://github.com/apache/spark/pull/46692#discussion_r1609159915
##########
connector/kafka-0-10-sql/src/main/resources/error/kafka-error-conditions.json:
##########
@@ -23,6 +23,13 @@
"latest offset: <latestOffset>, end offset: <endOffset>"
]
},
+ "KAFKA_START_OFFSET_DOES_NOT_MATCH_ASSIGNED" : {
+ "message" : [
+ "Partitions specified for Kafka start offsets don't match what are
assigned. Maybe topic partitions are created ",
+ "or deleted while the query is running. Use -1 for latest, -2 for
earliest.",
+ "Specified: ${specifiedPartitions} Assigned: ${assignedPartitions}"
Review Comment:
We use `<>` for params in error message.
##########
connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaOffsetReaderSuite.scala:
##########
@@ -135,6 +135,25 @@ class KafkaOffsetReaderSuite extends QueryTest with
SharedSparkSession with Kafk
KafkaOffsetRange(tp, 2, LATEST, None)).sortBy(_.topicPartition.toString))
}
+ testWithAllOffsetFetchingSQLConf(
+ "SPARK-48383: START_OFFSET_DOES_NOT_MATCH_ASSIGNED error class"
+ ) {
+ val topic = newTopic()
+ testUtils.createTopic(topic, partitions = 3)
+ val reader = createKafkaReader(topic, minPartitions = Some(4))
+
+ // There are three topic partitions, but we only include two in offsets.
+ val tp1 = new TopicPartition(topic, 0)
+ val tp2 = new TopicPartition(topic, 1)
+ val startingOffsets = SpecificOffsetRangeLimit(Map(tp1 -> EARLIEST, tp2 ->
EARLIEST))
+ val endingOffsets = SpecificOffsetRangeLimit(Map(tp1 -> LATEST, tp2 -> 3))
+
+ val ec = intercept[KafkaIllegalStateException] {
Review Comment:
Shall we use checkError to verify the error class related exception? Please
let me know if it's not available for Kafka exceptions having error class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
