HyukjinKwon commented on code in PR #46683:
URL: https://github.com/apache/spark/pull/46683#discussion_r1609223886
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -73,6 +73,11 @@ class SparkSession private[sql] (
with Logging {
private[this] val allocator = new RootAllocator()
+ private var shouldStopCleaner = false
+ private[sql] lazy val cleaner = {
+ shouldStopCleaner = true
+ new ContextCleaner(this)
Review Comment:
The problem is that the interface forces to fix generated code
`org.apache.spark.connect.proto.CachedRemoteRelation` to inherit
`AutoCloseable`, or I have to create a wrapper (see
https://docs.oracle.com/javase/9/docs/api/java/lang/ref/Cleaner.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
