Ngone51 commented on code in PR #46706:
URL: https://github.com/apache/spark/pull/46706#discussion_r1610891061
##########
core/src/main/scala/org/apache/spark/MapOutputTracker.scala:
##########
@@ -224,7 +227,9 @@ private class ShuffleStatus(
logDebug(s"Removing existing map output ${mapIndex} ${bmAddress}")
if (mapStatuses(mapIndex) != null && mapStatuses(mapIndex).location ==
bmAddress) {
_numAvailableMapOutputs -= 1
- mapStatusesDeleted(mapIndex) = mapStatuses(mapIndex)
+ val currentMapStatus = mapStatuses(mapIndex)
+ mapIdToMapIndex.remove(currentMapStatus.mapId)
Review Comment:
This is a good point. But IIUC, `mapStatusesDeleted` will only be cleanedup
when there is recovery happen using K8s. So it's not guaranteed to be always
cleaned up in the end. I removed the dependency of `mapIdToMapIndex` for
`mapStatusesDeleted` as it's not a common use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
