bozhang2820 commented on code in PR #46641:
URL: https://github.com/apache/spark/pull/46641#discussion_r1611182481
##########
core/src/main/scala/org/apache/spark/deploy/worker/ExecutorRunner.scala:
##########
@@ -206,11 +206,11 @@ private[deploy] class ExecutorRunner(
case interrupted: InterruptedException =>
logInfo("Runner thread for executor " + fullId + " interrupted")
state = ExecutorState.KILLED
- killProcess(None)
+ killProcess(s"Runner thread for executor $fullId interrupted")
case e: Exception =>
logError("Error running executor", e)
state = ExecutorState.FAILED
- killProcess(Some(e.toString))
+ killProcess(s"Error running executor: $e")
Review Comment:
The message will be sent to Master and Driver. Do you think including the
full stacktrace might make it too large? How about logging it in the Worker log
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
