dongjoon-hyun commented on code in PR #46716:
URL: https://github.com/apache/spark/pull/46716#discussion_r1611967474
##########
core/src/main/scala/org/apache/spark/metrics/sink/PrometheusServlet.scala:
##########
@@ -24,15 +24,21 @@ import jakarta.servlet.http.HttpServletRequest
import org.eclipse.jetty.servlet.ServletContextHandler
import org.apache.spark.SparkConf
+import org.apache.spark.annotation.{DeveloperApi, Since, Unstable}
import org.apache.spark.ui.JettyUtils._
/**
+ * :: DeveloperApi ::
* This exposes the metrics of the given registry with Prometheus format.
*
* The output is consistent with /metrics/json result in terms of item ordering
* and with the previous result of Spark JMX Sink + Prometheus JMX Converter
combination
* in terms of key string format.
+ *
+ * This is used by Spark MetricsSystem internally and Spark K8s operator.
*/
+@Unstable
+@DeveloperApi
Review Comment:
Why do we have `PrometheusPullModelSink` in `K8s Operator` repository
instead of here, @jiangzho ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
