HyukjinKwon commented on code in PR #46762:
URL: https://github.com/apache/spark/pull/46762#discussion_r1616433003
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationSupport.java:
##########
@@ -534,8 +534,10 @@ public static UTF8String exec(
CollationFactory.Collation collation =
CollationFactory.fetchCollation(collationId);
if (collation.supportsBinaryEquality) {
return execBinary(srcString);
- } else {
+ } else if (collation.supportsLowercaseEquality) {
return execLowercase(srcString);
+ } else {
+ return execLowercase(srcString); // TODO: ICU implementation
Review Comment:
Let's file a JIRA and tag it together with TODO. e.g., `TODO(SPARK-XXXXX):
ICU implementation` if you're not doing this in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
