amaliujia commented on code in PR #46778:
URL: https://github.com/apache/spark/pull/46778#discussion_r1618204541
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -1108,35 +1110,31 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
test("dynamic partition value test") {
- try {
- sql("set hive.exec.dynamic.partition.mode=nonstrict")
- // date
- sql("drop table if exists dynparttest1")
- sql("create table dynparttest1 (value int) partitioned by (pdate date)")
- sql(
- """
- |insert into table dynparttest1 partition(pdate)
- | select count(*), cast('2015-05-21' as date) as pdate from src
- """.stripMargin)
- checkAnswer(
- sql("select * from dynparttest1"),
- Seq(Row(500, java.sql.Date.valueOf("2015-05-21"))))
+ withTable("dynparttest1", "dynparttest2") {
+ withSQLConf("hive.exec.dynamic.partition.mode" -> "strict") {
+ sql("set hive.exec.dynamic.partition.mode=nonstrict")
Review Comment:
So previous code does something like
1. set the mode
2. the recover it by the finally so other test cases are not impacted.
The new code also set the mode, and recover it by `withSQLConf`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
