uros-db commented on code in PR #46640:
URL: https://github.com/apache/spark/pull/46640#discussion_r1622383424
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExprUtils.scala:
##########
@@ -169,7 +169,11 @@ object ExprUtils extends QueryErrorsBase {
a.failAnalysis(
errorClass = "MISSING_GROUP_BY",
messageParameters = Map.empty)
- case e: Attribute if !a.groupingExpressions.exists(_.semanticEquals(e))
=>
+ case e: Attribute if !a.groupingExpressions.exists {
Review Comment:
correct, this is not needed - we won't need to "match" aggregate and
grouping expressions with collationKey, since we only support collationKey
injection for "pure" grouping aggregation on collated string columns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
