dtenedor commented on code in PR #46594:
URL: https://github.com/apache/spark/pull/46594#discussion_r1622714544


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala:
##########
@@ -525,7 +525,7 @@ private[sql] object CatalogV2Util {
     }
 
     if (isDefaultColumn) {
-      val e = analyze(f, EXISTS_DEFAULT_COLUMN_METADATA_KEY)
+      val e = analyze(f, statementType = "Column conversion", 
EXISTS_DEFAULT_COLUMN_METADATA_KEY)

Review Comment:
   At any rate, this looks like the right fix!



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala:
##########
@@ -525,7 +525,7 @@ private[sql] object CatalogV2Util {
     }
 
     if (isDefaultColumn) {
-      val e = analyze(f, EXISTS_DEFAULT_COLUMN_METADATA_KEY)
+      val e = analyze(f, statementType = "Column conversion", 
EXISTS_DEFAULT_COLUMN_METADATA_KEY)

Review Comment:
   ```suggestion
         val e = analyze(
           field = f,
           statementType = "Column conversion",
           metadataKey = EXISTS_DEFAULT_COLUMN_METADATA_KEY)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to