gengliangwang commented on code in PR #46824:
URL: https://github.com/apache/spark/pull/46824#discussion_r1622849741
##########
common/utils/src/main/scala/org/apache/spark/internal/Logging.scala:
##########
@@ -158,7 +159,7 @@ trait Logging {
}
}
- MessageWithContext(sb.toString(), context)
+ MessageWithContext(StringEscapeUtils.unescapeJava(sb.toString()),
context)
Review Comment:
shall we change
```
class LogEntry(messageWithContext: => MessageWithContext) {
def message: String = messageWithContext.message
```
instead?
There are many log concations. We should avoid calling the method
`unescapeJava` for all the log fragments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
