HyukjinKwon commented on code in PR #46833:
URL: https://github.com/apache/spark/pull/46833#discussion_r1623707324
##########
python/pyspark/sql/datasource.py:
##########
@@ -654,7 +654,7 @@ def abort(self, messages: List["WriterCommitMessage"]) ->
None:
Parameters
----------
messages : list of :class:`WriterCommitMessage`\\s
- A list of commit messages.
+ A list of commit messages. Can contain `None` values if any task
failed.
Review Comment:
`List[Optional["WriterCommitMessage"]]`
I would change the type hint too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
