LuciferYang commented on PR #46783: URL: https://github.com/apache/spark/pull/46783#issuecomment-2144518060
@yaooqinn Although the logic is a bit convoluted, I am confident that the following two cases cover the scenarios where isG1GC is true and false, respectively. https://github.com/apache/spark/blob/8d9d9c243ed141660e853b189982979d19f0ba9d/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala#L145-L159 These two cases executed `org.apache.spark.examples.DriverSubmissionTest`, intercepted the logs, and checked the return value of `Utils.isG1GC` in the logs. https://github.com/apache/spark/blob/8d9d9c243ed141660e853b189982979d19f0ba9d/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala#L306-L343 https://github.com/apache/spark/blob/8d9d9c243ed141660e853b189982979d19f0ba9d/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala#L656 https://github.com/apache/spark/blob/8d9d9c243ed141660e853b189982979d19f0ba9d/examples/src/main/scala/org/apache/spark/examples/DriverSubmissionTest.scala#L46 and they passed  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
