itholic commented on code in PR #46836:
URL: https://github.com/apache/spark/pull/46836#discussion_r1625228304
##########
python/pyspark/sql/tests/test_utils.py:
##########
@@ -955,13 +954,8 @@ def test_assert_error_pandas_pyspark_df(self):
exception=pe.exception,
error_class="INVALID_TYPE_DF_EQUALITY_ARG",
message_parameters={
- "expected_type": f"{ps.DataFrame.__name__}, "
- f"{pd.DataFrame.__name__}, "
- f"{ps.Series.__name__}, "
- f"{pd.Series.__name__}, "
- f"{ps.Index.__name__}"
- f"{pd.Index.__name__}, ",
- "arg_name": "expected",
+ "expected_type": "Pandas or Pandas-on-Spark DataFrame, Series,
or Index",
Review Comment:
+1 This one looks more clearer to me.
##########
python/pyspark/pandas/tests/indexes/test_indexing_adv.py:
##########
@@ -69,7 +69,7 @@ def test_at(self):
self.assertEqual(psdf.at[3, "b"], 6)
self.assertEqual(psdf.at[3, "b"], pdf.at[3, "b"])
self.assert_eq(psdf.at[9, "b"], np.array([0, 0, 0]))
- self.assert_eq(psdf.at[9, "b"], pdf.at[9, "b"])
+ self.assert_eq(psdf.at[9, "b"], pdf.at[9, "b"].to_numpy())
Review Comment:
I believe the previous one looks more reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
