uros-db commented on PR #46597: URL: https://github.com/apache/spark/pull/46597#issuecomment-2147480288
Hey @GideonPotok, thanks for the ping and sorry for the delay! I'll make sure to remind folks from the SQL team to take a look at this and give some feedback themselves. I'd say it's fine if you want to proceed with covering all complex types with collated strings, as we don't currently have any other open tickets within the collation effort On the other hand, I'd advise some more patience while we gather some input from @dbatomic @stefankandic @nikolamand-db @mihailom-db @stevomitric on whether this would be the correct general approach. From where I see it - this is good enough for a starting point. But, the team may have some other ideas for this, or they may prefer the _using collationKeys for aggregation with a separate map to preserve original strings so they don't get lost_ approach, so I think it's best to hear them out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
