hvanhovell commented on code in PR #46849:
URL: https://github.com/apache/spark/pull/46849#discussion_r1626853395
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/Aggregator.scala:
##########
@@ -52,7 +56,7 @@ import org.apache.spark.sql.{Encoder, TypedColumn}
* @since 4.0.0
*/
@SerialVersionUID(2093413866369130093L)
-abstract class Aggregator[-IN, BUF, OUT] extends Serializable {
+abstract class Aggregator[-IN: TypeTag, BUF, OUT] extends Serializable {
Review Comment:
There are a few concerns here:
- How does this work with java implementations? How ugly is this going to
be. You probably want to add a def inputEncoder: Encoder[IN] as well.
- This is a breaking change compared to the sql/core class. I am fine adding
this. However I'd probably homogenise the implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
