cloud-fan commented on code in PR #46890:
URL: https://github.com/apache/spark/pull/46890#discussion_r1629119432
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala:
##########
@@ -1247,14 +1247,13 @@ abstract class CSVSuite
val exp = spark.sql("select timestamp_ntz'2020-12-12 12:12:12' as col0")
for (pattern <- patterns) {
withTempPath { path =>
- val actualPath = path.toPath.toUri.toURL.toString
val ex = intercept[SparkException] {
exp.write.format("csv").option("timestampNTZFormat",
pattern).save(path.getAbsolutePath)
}
checkErrorMatchPVals(
exception = ex,
errorClass = "TASK_WRITE_FAILED",
- parameters = Map("path" -> s"$actualPath.*"))
+ parameters = Map("path" -> s".*${path.getName}.*"))
Review Comment:
not quite related but since I touched this suite, I tried to make the test
code more consistent about checking path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
