cloud-fan commented on code in PR #44976:
URL: https://github.com/apache/spark/pull/44976#discussion_r1630428579


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala:
##########
@@ -1032,7 +1026,11 @@ class SimpleTableFunctionRegistry extends 
SimpleFunctionRegistryBase[LogicalPlan
 
   override def clone(): SimpleTableFunctionRegistry = synchronized {

Review Comment:
   I think there is a problem here. We don't synchronize the write path, how 
can we safely clone the `ConcurrentHashMap`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to