mkaravel commented on code in PR #46720:
URL: https://github.com/apache/spark/pull/46720#discussion_r1630676281
##########
common/unsafe/src/test/java/org/apache/spark/unsafe/types/CollationSupportSuite.java:
##########
@@ -494,10 +494,10 @@ public void testUpper() throws SparkException {
assertUpper("ab世De", "UNICODE_CI", "AB世DE");
assertUpper("äbćδe", "UNICODE_CI", "ÄBĆΔE");
// Case-variable character length
- assertUpper("i̇o", "UTF8_BINARY","İO");
- assertUpper("i̇o", "UTF8_BINARY_LCASE","İO");
- assertUpper("i̇o", "UNICODE","İO");
- assertUpper("i̇o", "UNICODE_CI","İO");
+ assertUpper("i\u0307o", "UTF8_BINARY","I\u0307O");
+ assertUpper("i\u0307o", "UTF8_BINARY_LCASE","I\u0307O");
+ assertUpper("i\u0307o", "UNICODE","I\u0307O");
+ assertUpper("i\u0307o", "UNICODE_CI","I\u0307O");
Review Comment:
Please add some _interesting_ test cases for uppercasing, notably strings
that involve ligatures or characters that map to multiple characters when
uppercased:
```scala
assertUpper("ß fi ffi ff st ῗ", "UTF8_BINARY","SS FI FFI FF ST
\u0399\u0308\u0342");
assertUpper("ß fi ffi ff st ῗ", "UTF8_BINARY_LCASE","SS FI FFI FF ST
\u0399\u0308\u0342");
assertUpper("ß fi ffi ff st ῗ", "UNICODE","SS FI FFI FF ST \u0399\u0308\u0342");
assertUpper("ß fi ffi ff st ῗ", "UNICODE","SS FI FFI FF ST \u0399\u0308\u0342");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
