szehon-ho commented on code in PR #46707:
URL: https://github.com/apache/spark/pull/46707#discussion_r1631776812
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -823,13 +823,17 @@ identifierComment
relationPrimary
: identifierReference temporalClause?
- sample? tableAlias #tableName
+ sample? optionsClause? tableAlias #tableName
| LEFT_PAREN query RIGHT_PAREN sample? tableAlias #aliasedQuery
| LEFT_PAREN relation RIGHT_PAREN sample? tableAlias #aliasedRelation
| inlineTable
#inlineTableDefault2
| functionTable
#tableValuedFunction
;
+optionsClause
+ : WITH OPTIONS options=propertyList
Review Comment:
Change back to WITH OPTIONS , checking is it @cloud-fan 's suggestion?
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -823,13 +823,17 @@ identifierComment
relationPrimary
: identifierReference temporalClause?
- sample? tableAlias #tableName
+ sample? optionsClause? tableAlias #tableName
| LEFT_PAREN query RIGHT_PAREN sample? tableAlias #aliasedQuery
| LEFT_PAREN relation RIGHT_PAREN sample? tableAlias #aliasedRelation
| inlineTable
#inlineTableDefault2
| functionTable
#tableValuedFunction
;
+optionsClause
+ : WITH OPTIONS options=propertyList
Review Comment:
Changed back to WITH OPTIONS , checking is it @cloud-fan 's suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
