JoshRosen commented on code in PR #46919:
URL: https://github.com/apache/spark/pull/46919#discussion_r1632089466
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala:
##########
@@ -120,7 +120,14 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
* ineffective for subsequent apply calls on this tree because query plan
structures are
* immutable.
*/
- private val ineffectiveRules: BitSet = new BitSet(RuleIdCollection.NumRules)
+ private[this] var _ineffectiveRules: BitSet = null
+ private def ineffectiveRules: BitSet = {
+ if (_ineffectiveRules eq null) {
+ _ineffectiveRules = new BitSet(RuleIdCollection.NumRules)
+ }
+ _ineffectiveRules
+ }
+ private def isIneffectiveRulesEmpty = _ineffectiveRules == null
Review Comment:
On re-review, I think this should be
```suggestion
private def isIneffectiveRulesEmpty = _ineffectiveRules eq null
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
