pan3793 commented on PR #46947:
URL: https://github.com/apache/spark/pull/46947#issuecomment-2162199044
@gengliangwang It might be aggressive to ban all `log{Info|Warning|Error}`
calls with string at the current stage, especially without SPARK-47688.
I suppose that the values defined in LogKeys are public APIs, and they
should not be removed after 4.0.0 is released. Well, the current list might
need to be polished, for example, `ALPHA`, `BOOT`, `INIT` might be too general
to represent the concrete concept, they were exposed because the current
implementation requires all substitutable variables MUST be a `LogKeys`. For
keys like `*_TIME`, some values have the unit but some do not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
