HeartSaVioR commented on PR #46953: URL: https://github.com/apache/spark/pull/46953#issuecomment-2162380811
One side note, I see some logical nodes to override the method `simpleString`, which removes out the chance for marker to be added. Not sure it is intentional, but maybe better to think through the way to ensure statePrefix is always available for the simpleString, so that the marker is always showing up in logical plan for plan change logger. Probably even better if we could ensure the property of isStreaming value to be available for `verboseString`, `simpleStringWithNodeId`, `verboseStringWithOperatorId`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
