yaooqinn commented on code in PR #46938:
URL: https://github.com/apache/spark/pull/46938#discussion_r1636030820
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogUtils.scala:
##########
@@ -97,31 +98,40 @@ object ExternalCatalogUtils {
}
def unescapePathName(path: String): String = {
- val sb = new StringBuilder
- var i = 0
-
- while (i < path.length) {
- val c = path.charAt(i)
- if (c == '%' && i + 2 < path.length) {
- val code: Int = try {
- Integer.parseInt(path.substring(i + 1, i + 3), 16)
- } catch {
- case _: Exception => -1
- }
- if (code >= 0) {
- sb.append(code.asInstanceOf[Char])
- i += 3
+ if (path == null || path.isEmpty) {
+ return path
+ }
+ var plaintextEndIdx = path.indexOf('%')
+ val length = path.length
+ if (plaintextEndIdx == -1 || plaintextEndIdx + 2 > path.length) {
Review Comment:
I'm sorry, I'm having a little trouble understanding your suggestion. Can
you please clarify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
