davidm-db commented on code in PR #46665:
URL: https://github.com/apache/spark/pull/46665#discussion_r1636117355
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -117,6 +118,57 @@ class AstBuilder extends DataTypeAstBuilder with
SQLConfHelper with Logging {
}
}
+ override def visitCompoundOrSingleStatement(
+ ctx: CompoundOrSingleStatementContext): CompoundBody = {
+ Option(ctx.singleCompoundStatement()).map { s =>
+ visit(s).asInstanceOf[CompoundBody]
+ }.getOrElse {
+ val logicalPlan = visitSingleStatement(ctx.singleStatement())
+ CompoundBody(Seq(SingleStatement(
+ parsedPlan = logicalPlan,
+ sourceStart = ctx.start.getStartIndex,
+ sourceEnd = ctx.stop.getStopIndex + 1)))
+ }
+ }
+
+ override def visitSingleCompoundStatement(ctx:
SingleCompoundStatementContext): CompoundBody = {
+ visit(ctx.beginEndCompoundBlock()).asInstanceOf[CompoundBody]
+ }
+
+ private def visitCompoundBodyImpl(ctx: CompoundBodyContext): CompoundBody = {
+ val buff = ListBuffer[CompoundPlanStatement]()
+ for (i <- 0 until ctx.getChildCount) {
+ val child = ctx.getChild(i)
+ val visitedChild = visit(ctx.getChild(i))
+ visitedChild match {
+ case statement: CompoundPlanStatement => buff += statement
+ case null if child.isInstanceOf[TerminalNodeImpl] =>
+ }
+ }
+
+ CompoundBody(buff.toSeq)
+ }
+
+ override def visitBeginEndCompoundBlock(ctx: BeginEndCompoundBlockContext):
CompoundBody = {
+ visitCompoundBodyImpl(ctx.compoundBody())
+ }
+
+ override def visitCompoundBody(ctx: CompoundBodyContext): CompoundBody = {
+ visitCompoundBodyImpl(ctx)
+ }
+
+ override def visitCompoundStatement(ctx: CompoundStatementContext):
CompoundPlanStatement = {
+ val child = visit(ctx.getChild(0))
Review Comment:
Do you mean like checking if we are visiting `statement` or
`beginEndCompoundBlock` first and then do the visit, instead of visiting first
and than matching on the output type?
I will change it to this anyways because I think it makes more sense and it
cleaner than `getChild(0)` etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
