panbingkun commented on code in PR #46937:
URL: https://github.com/apache/spark/pull/46937#discussion_r1636310935
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -740,15 +740,16 @@ abstract class JdbcDialect extends Serializable with
Logging {
* @param e The dialect specific exception.
* @param errorClass The error class assigned in the case of an unclassified
`e`
* @param messageParameters The message parameters of `errorClass`
- * @param description The error description
* @return `AnalysisException` or its sub-class.
*/
def classifyException(
e: Throwable,
errorClass: String,
- messageParameters: Map[String, String],
- description: String): AnalysisException = {
Review Comment:
Yeah, that's right, see PR below:
1.https://github.com/apache/spark/pull/44358, the modification of this PR
resulted in `break changes`, and with the suggestion of `cloud-fan`:
<img width="856" alt="image"
src="https://github.com/apache/spark/assets/15246973/ded0b7db-932d-4959-bfdf-c72cadcb1755";>
the following PR has been created.
2.https://github.com/apache/spark/pull/44449, this PR has restored
compatibility behavior
<img width="891" alt="image"
src="https://github.com/apache/spark/assets/15246973/3a6a0ca2-c3d9-4b3d-8dfc-5c9e637a6bb6";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
