cloud-fan commented on code in PR #46830:
URL: https://github.com/apache/spark/pull/46830#discussion_r1637513428
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AQEPropagateEmptyRelation.scala:
##########
@@ -34,11 +35,14 @@ import
org.apache.spark.sql.execution.joins.HashedRelationWithAllNullKeys
*/
object AQEPropagateEmptyRelation extends PropagateEmptyRelationBase {
override protected def isEmpty(plan: LogicalPlan): Boolean =
- super.isEmpty(plan) || (!isRootRepartition(plan) &&
getEstimatedRowCount(plan).contains(0))
+ super.isEmpty(plan) || plan.isInstanceOf[EmptyRelation] ||
Review Comment:
I think it's more reasonable to make `getEstimatedRowCount` recognize this
new `EmptyRelation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
