yaooqinn commented on code in PR #46972:
URL: https://github.com/apache/spark/pull/46972#discussion_r1639339702
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala:
##########
@@ -1162,41 +1140,27 @@ case class Unhex(child: Expression, failOnError:
Boolean = false)
override def dataType: DataType = BinaryType
protected override def nullSafeEval(num: Any): Any = {
- val result = Hex.unhex(num.asInstanceOf[UTF8String].getBytes)
- if (failOnError && result == null) {
- // The failOnError is set only from `ToBinary` function - hence we might
safely set `hint`
- // parameter to `try_to_binary`.
- throw QueryExecutionErrors.invalidInputInConversionError(
- BinaryType,
- num.asInstanceOf[UTF8String],
- UTF8String.fromString("HEX"),
- "try_to_binary")
+ try {
+ Hex.unhex(num.asInstanceOf[UTF8String].toString)
Review Comment:
Good point, let me implement unhex directly on bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
