LuciferYang commented on code in PR #46962:
URL: https://github.com/apache/spark/pull/46962#discussion_r1639368506
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -2015,27 +2015,38 @@ private[spark] object Utils
}
}
+ private[util] val threadInfoOrdering = Ordering.fromLessThan {
Review Comment:
I prefer to use `PrivateMethodTester` during testing rather than expanding
its scope.
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -2015,27 +2015,38 @@ private[spark] object Utils
}
}
+ private[util] val threadInfoOrdering = Ordering.fromLessThan {
+ (threadTrace1: ThreadInfo, threadTrace2: ThreadInfo) => {
+ def priority(ti: ThreadInfo): Int = ti.getThreadName match {
+ case name if name.contains("Executor task launch") => 3
+ case "Driver" => 2
Review Comment:
https://github.com/apache/spark/pull/46962#issuecomment-2163311959
not related to this pr: Although there is a test case, it might be better to
make the literal of this identifier linkable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
