zhengruifeng commented on code in PR #46901:
URL: https://github.com/apache/spark/pull/46901#discussion_r1639489575


##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -10926,6 +10928,9 @@ def substring(str: "ColumnOrName", pos: int, len: int) 
-> Column:
     .. versionchanged:: 3.4.0
         Supports Spark Connect.
 
+    .. versionchanged:: 4.0.0

Review Comment:
   let's move it under parameters section, you may refer to
   
   
https://github.com/apache/spark/blob/bb1f026da0e3193e0cfad2001c7a8cab59a5290a/python/pyspark/sql/functions/builtin.py#L6216-L6220



##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -14397,12 +14427,15 @@ def array_remove(col: "ColumnOrName", element: Any) 
-> Column:
     .. versionchanged:: 3.4.0
         Supports Spark Connect.
 
+    .. versionchanged:: 4.0.0

Review Comment:
   ditto



##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -13959,6 +13973,9 @@ def array_position(col: "ColumnOrName", value: Any) -> 
Column:
     .. versionchanged:: 3.4.0
         Supports Spark Connect.
 
+    .. versionchanged:: 4.0.0

Review Comment:
   ditto



##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -17232,12 +17277,15 @@ def map_contains_key(col: "ColumnOrName", value: Any) 
-> Column:
     .. versionchanged:: 3.4.0
         Supports Spark Connect.
 
+    .. versionchanged:: 4.0.0

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to