uros-db commented on code in PR #46917:
URL: https://github.com/apache/spark/pull/46917#discussion_r1640081873


##########
sql/core/benchmarks/CollationBenchmark-results.txt:
##########


Review Comment:
   so let's revise the current approach (OHM):
   
   - slightly less performant than GroupMapReduce
   - considerably more complicated implementation
   
   with all this in mind, I suggest we close this discussion and choose 
GroupMapReduce
   
   @dbatomic final opinion?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to