allisonwang-db commented on code in PR #46902:
URL: https://github.com/apache/spark/pull/46902#discussion_r1640230383
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala:
##########
@@ -274,7 +278,9 @@ object SubExprUtils extends PredicateHelper {
plan match {
case Filter(cond, child) =>
val correlated = AttributeSet(splitConjunctivePredicates(cond)
- .filter(containsOuter) // TODO: can remove this line to allow e.g.
where x = 1 group by x
+ .filter(
+
SQLConf.get.getConf(SQLConf.SCALAR_SUBQUERY_ALLOW_GROUP_BY_COLUMN_EQUAL_TO_CONSTANT)
Review Comment:
Yea I think we can remove this config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
