panbingkun commented on code in PR #46951:
URL: https://github.com/apache/spark/pull/46951#discussion_r1642072333
##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala:
##########
@@ -989,9 +989,11 @@ private[spark] class TaskSetManager(
if (ef.className ==
classOf[TaskOutputFileAlreadyExistException].getName) {
// If we can not write to output file in the task, there's no point
in trying to
// re-execute it.
- logError(log"Task ${MDC(TASK_ID, info.id)} in stage ${MDC(STAGE_ID,
taskSet.id)} " +
- log"(TID ${MDC(TID, tid)}) can not write to output file: " +
- log"${MDC(ERROR, ef.description)}; not retrying")
+ logError(
+ log"Task ${MDC(TASK_INDEX, info.index)}.${MDC(TASK_ATTEMPT_ID,
info.attemptNumber)} " +
+ log"in stage ${MDC(STAGE_ID, taskSet.stageId)}." +
Review Comment:
Can we unify the writing style of `taskSet.logid`?
<img width="473" alt="image"
src="https://github.com/apache/spark/assets/15246973/b2024a58-1b7e-452c-a2c8-04eba47c94e1";>
the current writing style more consistent with traditional styles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
