cloud-fan commented on code in PR #46987:
URL: https://github.com/apache/spark/pull/46987#discussion_r1642274556


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -78,6 +78,11 @@ object CollationTypeCasts extends TypeCoercionRule {
       }
       raiseError.withNewChildren(Seq(raiseError.errorClass, newErrorParams))
 
+    case framelessOffsetWindow @ (_: Lag | _: Lead) =>

Review Comment:
   so we only want to allow implicit cast for lead/lag regarding string 
collations?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to