grundprinzip commented on code in PR #46993:
URL: https://github.com/apache/spark/pull/46993#discussion_r1642328868
##########
python/pyspark/sql/connect/client/reattach.py:
##########
@@ -206,8 +216,8 @@ def target() -> None:
except Exception as e:
warnings.warn(f"ReleaseExecute failed with exception: {e}.")
- if ExecutePlanResponseReattachableIterator._release_thread_pool is not
None:
-
ExecutePlanResponseReattachableIterator._release_thread_pool.apply_async(target)
+ if not self._is_shutdown:
+ self._release_thread_pool.apply_async(target)
Review Comment:
This code is a bit confusing to me, but it might simply because of the way
Python works. My understanding was that self only gives me access to instance
but not class variables, but _release_thread_pool is an actual class variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
