unigof commented on code in PR #46958:
URL: https://github.com/apache/spark/pull/46958#discussion_r1642395869
##########
sql/core/src/test/scala/org/apache/spark/sql/CharVarcharTestSuite.scala:
##########
@@ -1064,6 +1064,34 @@ class FileSourceCharVarcharTestSuite extends
CharVarcharTestSuite with SharedSpa
}
}
}
+
+ test("SPARK-48498: always do char padding in predicates") {
+ import testImplicits._
+ withSQLConf(SQLConf.READ_SIDE_CHAR_PADDING.key -> "false") {
Review Comment:
cloud you add a test for conf `LEGACY_NO_CHAR_PADDING_IN_PREDICATE`?
It maybe would fail when `LEGACY_NO_CHAR_PADDING_IN_PREDICATE` = true
https://github.com/apache/spark/pull/46832/files?diff=split&w=1#r1642368622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
