bozhang2820 commented on code in PR #46989:
URL: https://github.com/apache/spark/pull/46989#discussion_r1642759225
##########
core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala:
##########
@@ -392,7 +391,7 @@ class ShuffleBlockFetcherIteratorSuite extends
SparkFunSuite with PrivateMethodT
configureMockTransfer(Map())
val iterator = createShuffleBlockIteratorWithDefaults(
- Map(hostLocalBmId -> toBlockList(hostLocalBlocks.keys, 1L, 1))
+ Map(blockManager.blockManagerId -> toBlockList(hostLocalBlocks.keys, 1L,
1))
Review Comment:
That's correct. Thanks for catching!
It seems that for the original code, `blockManager.hostLocalDirManager` was
not mocked correctly and it returns `None`. I'm trying to figure out how to
mock it correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
