HyukjinKwon commented on code in PR #46789:
URL: https://github.com/apache/spark/pull/46789#discussion_r1644013715


##########
python/pyspark/sql/connect/expressions.py:
##########
@@ -89,7 +90,16 @@ class Expression:
     """
 
     def __init__(self) -> None:
-        pass
+        origin = current_origin()
+        fragment = origin.fragment
+        call_site = origin.call_site

Review Comment:
   I don't quite like this too actually. Yes, we can pass the explicit callsite 
around. It happened to be like this to match the implementation across Catalyst 
Optimizer, Scala, and PySpark w/ Spark Classic.
   
   Let me revisit this to fix up Spark Classic side together and see if we can 
do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to